Respect installing project in virtualenv in builder #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
added a commit
that referenced
this pull request
Aug 20, 2015
Respect installing project in virtualenv in builder
| @@ -141,7 +141,7 @@ class Project(models.Model): | |||
| skip = models.BooleanField(_('Skip'), default=False) | |||
| mirror = models.BooleanField(_('Mirror'), default=False) | |||
| use_virtualenv = models.BooleanField( | |||
| _('Use virtualenv'), | |||
| _('Install Project'), | |||
There was a problem hiding this comment.
Please keep in mind that changing any field argument will require adjustments in the migrations:
(See the "Alter field use_virtualenv on project")
I usually go the way to change the verbose_name of the original migration which introduced the field since I'm 100% sure that this change will not affect the DB. The other probably cleaner solution (which is causing other problems when using many long lived feature branches) is to create a new migration that changes the field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.